Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add workflow for testing Optimism every night #638

Merged
merged 7 commits into from
Sep 6, 2024
Merged

ci: add workflow for testing Optimism every night #638

merged 7 commits into from
Sep 6, 2024

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Aug 30, 2024 •
edited
Loading

This PR adds support for replaying Optimism on-chain blocks to the CLI app and adds a GitHub workflow for nightly replays of the latest Optimism block.

This PR contains a breaking change to the CLI:

  • --chain-id was removed as it can be retrieved from the remote
  • --chain-type was added, replacing the meaning of -c from --chain-id to --chain-type

Once merged, this PR commit should be cherry-picked and applied to main to ensure that the on.schedule works.

Scheduled workflows will only run on the default branch.

https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#schedule

@Wodann Wodann added the no changeset needed This PR doesn't require a changeset label Aug 30, 2024
@Wodann Wodann self-assigned this Aug 30, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5805442

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Wodann Wodann had a problem deploying to github-action-benchmark August 30, 2024 20:07 — with GitHub Actions Error
@Wodann Wodann temporarily deployed to github-action-benchmark August 30, 2024 20:12 — with GitHub Actions Inactive
@Wodann Wodann requested a review from a team August 30, 2024 21:05
@Wodann Wodann marked this pull request as ready for review August 30, 2024 21:05
@Wodann Wodann temporarily deployed to github-action-benchmark August 30, 2024 21:06 — with GitHub Actions Inactive
galargh
galargh reviewed Sep 2, 2024
View reviewed changes
Copy link
Member

@galargh galargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had a quick look at the GHA part of the PR, looks nice :)

.github/workflows/test-recent-optimism-block.yml Outdated Show resolved Hide resolved
.github/workflows/test-recent-mainnet-block.yml
@@ -33,11 +33,9 @@ jobs:

- name: Run test
uses: actions-rs/cargo@v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, https://github.com/actions-rs has been archived last year and the actions repos haven't been updated for quite a while. I think it'd be nice to replace them, but maybe best to do it in a separate PR - I could propose it some time this week if you like the idea.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we use this across all of our GitHub actions, it would be good to do it in a follow-up task.

I created one in our backlog: #642

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a somewhat related note, do we need actions-rs/cargo (cargo specifically) at all? It seem to be just running cargo and we don't seem to need any cross-compilation or other target specs in general (which could be noisy, I guess), so this might be a regular run step, instead.

Copy link
Member

@fvictorio fvictorio Sep 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to what @Xanewok said. I already replaced that action with a plain run step in some workflow some time ago. It's simpler, it's straightforward to understand what it does, and it means one external dependency less.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Off-topic for this PR though)

.github/workflows/test-recent-optimism-block.yml Outdated Show resolved Hide resolved
@Wodann @galargh
Update .github/workflows/test-recent-optimism-block.yml
57e883d 
Co-authored-by: Piotr Galar <piotr.galar@gmail.com>
@Wodann Wodann had a problem deploying to github-action-benchmark September 3, 2024 13:49 — with GitHub Actions Error
@Wodann @galargh
Update .github/workflows/test-recent-optimism-block.yml
2d3a652 
Co-authored-by: Piotr Galar <piotr.galar@gmail.com>
@Wodann Wodann temporarily deployed to github-action-benchmark September 3, 2024 13:50 — with GitHub Actions Inactive
@Wodann Wodann requested a review from fvictorio September 3, 2024 19:02
@Wodann
Copy link
Member Author

Wodann commented Sep 3, 2024

Thank you for the suggestions, @galargh! ❤️

@Wodann Wodann temporarily deployed to github-action-benchmark September 3, 2024 19:33 — with GitHub Actions Inactive
@Wodann Wodann linked an issue Sep 4, 2024 that may be closed by this pull request
Add CI job for replaying Optimism blocks every night #630
Closed
@Wodann Wodann temporarily deployed to github-action-benchmark September 6, 2024 03:52 — with GitHub Actions Inactive
@Wodann Wodann requested a review from fvictorio September 6, 2024 03:54
@Wodann Wodann merged commit 0a57886 into feat/multichain Sep 6, 2024
39 checks passed
@Wodann Wodann deleted the ci/test branch September 6, 2024 13:55
@Wodann Wodann mentioned this pull request Sep 6, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@galargh galargh galargh left review comments

@Xanewok Xanewok Xanewok left review comments

@fvictorio fvictorio fvictorio approved these changes

Assignees

@Wodann Wodann

Labels
no changeset needed This PR doesn't require a changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CI job for replaying Optimism blocks every night
4 participants
@Wodann @fvictorio @Xanewok @galargh